Repository navigation
Conversation
1 of 4 tasks
Email steps render a scaled preview of their HTML in the graph editor and the list view. Graph nodes for email steps are taller, so the layout and edge handles use each node's size. In dark mode the preview is inverted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Reuse EmailPreviewThumbnail so previews stay out of session replay and render the email at its 600px layout. Center the branch-join dropzone on wider email nodes, and invert the clipped thumbnail in dark mode so no white corners show. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Silthus
force-pushed
the
t3code/embedded-email-previews
branch
from
October 7, 2026 11:43
e8f6965 to
37e86bc
Compare
Owner
Author
|
Closing: the new workflow editor replaced the surface this changes, so this stack is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Feature flags. No feature flag controls the canvas preview and graph-layout changes.
Note
🔵 Merge risk: low (merge-risk rubric)
Fork handoff for source #111731. Modernized head
37e86bcbb0eac5209757a36d0b0bb2e62f93de96. This draft prepares review and recreation in the upstream repository.Changes
EmailPreviewThumbnail, which is sandboxed, runs no scripts, and keeps the HTML out of session replay withph-no-capture. Two sizes are added to it.function_emailsteps and for generic steps that use the email template.{{ person.properties.first_name }}.nodeSizehelper, and the story fixtures get a realistic email template.Before, an email step looked like every other step: a title card with no content. These screenshots replace the first upload, which showed an earlier iteration.
Note
Known limits:
How did you test this code?
Test rationale:
hogFlowEditorLogic.test.tsgets four cases. The closest existing tests, "graph identity across rebuilds" and "showDropzones branch-join placement", do not check sizes.function_emailand for generic email-template steps: fails when the layout or the edge handles ignore the email node size, which makes the preview overlap the next step.Verify with
hogli test products/workflows/frontend/Workflows/hogflows/hogFlowEditorLogic.test.ts. Expect 31 passing tests, including the "email step layout" block.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Modernization on
e8f6965466759: Preserves upstream zoom limits and UTM-default behavior. The editor logic suite, frontend TypeScript check, and strict preflight pass. Fresh browser rendering remains unchecked. Historical proof above describes the earlier head. Fresh CI remains unverified.Final freshness on
37e86bcbb0eac5209757a36d0b0bb2e62f93de96against upstream masterb75567aca6cce9f0499e882463fc7e71d65a064c: 69 backend and 72 frontend cases, full frontend TypeScript and strict preflight passed; full OpenAPI regeneration produced zero tracked drift. Upstream zoom behavior preserved while rebasing canvas preview sizing. Exact leases and ordinary pre-push gate verified. Prior proof remains historical. Fresh upstream CI and companion review remain unchecked.Release status
Fork handoff only. This task does not activate rollout flags. Upstream CI and the unavailable Opus review remain handoff gaps.
No feature flag controls this change
This change is behind a feature flag and is not available to users
This change makes a previously flagged feature available to everyone
Publish to changelog?
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5. Review panel: GPT-6.1 Sol through Codex, plus Claude Opus.
/tdd,/writing-tests,/writing-ui-components,/reviewing-with-coderabbit,/writing-pr-descriptions,/share-preview,/qa-swarm,/merge-risk,/leaving-pr-comments.EmailPreviewThumbnail, which fixed session replay capture and email media queries. It also found the generic email-template steps, the dropzone offset, and the sibling-row offset.dark:classes, not an inversion inside the email document. Storybook sets onlybody[theme], andcolor-schemedid not reach the iframe's media query in Chromium.🤖 Generated with Claude Code
Modernization: T3 Code, Codex, gpt-6.1-sol. Skills: modernize-pr, pr, writing-pr-descriptions, writing-voice, unslop, running-ci-preflight. A fresh Claude Opus 5.5 review attempt hit an API rate limit; the modernization review remains incomplete.